Fix outer loop access instances. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pattern: \s+<ForceConformanceInForLoopScope>false</ForceConformanceInForLoopScope>[\r\n] Token: \n
I used the following regex pattern to find them: (for\s*\(\s*(i|j)\s*=)|(\s*int\s*(i|j)\s*;) Note that this was done with extra cautious, because there were some instances where it was obviously necessary for the variable to be outside if it's being accessed in another usage. Other instances were not modified, as they flow of the function with goto functions was too hectic to change. Mostly noticed through the server codebase, where the engineers coded as if we're doing C in C++.
|
Build passing: https://github.com/stevewgr/ko/runs/7490726019?check_suite_focus=true Merging. |
|
This PR resolves: #34 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I used the following regex pattern to find them:
I used the following regex pattern to find them:
(for\s*\(\s*(i|j)\s*=)|(\s*int\s*(i|j)\s*;)or
i|j|k|m|n|l|o|p|x|z(case sensitive & full word) to highlight them while modifying the code.Note that this was done with extra cautious, because there were some instances
where it was obviously necessary for the variable to be outside if it's
being accessed in another usage.
Other instances were not modified, as they flow of the function with
goto functions was too hectic to change. Mostly noticed through the
server codebase, where the engineers coded as if we're doing C in C++.