Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update working directory, database default configs and docs. #75

Merged
merged 7 commits into from
Aug 8, 2022

Conversation

stevewgr
Copy link
Member

@stevewgr stevewgr commented Aug 8, 2022

Description

As we now fetch the ko-assets in a specific directory structure, for every project that depends on either the server or game assets, we set the working directory.

I also updated the defaults ini configurations for server database credentials, as well as updated the doucmentation.

@stevewgr stevewgr requested a review from xGuTeK August 8, 2022 18:48
@stevewgr stevewgr self-assigned this Aug 8, 2022
@GiRx8
Copy link
Contributor

GiRx8 commented Aug 8, 2022

Just a quick question, why are the map folders being split? (I know 1298 does it) but never understood the reasoning behind it.

Copy link
Contributor

@GiRx8 GiRx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the odbc connections being changed?

@stevewgr
Copy link
Member Author

stevewgr commented Aug 8, 2022

Just a quick question, why are the map folders being split? (I know 1298 does it) but never understood the reasoning behind it.

Great question! I'm not sure why at this point, since it's how it's setup with the official server files, even in 1298 version, but looks like the *.evt files are different. Maybe that explains.
I remember also trying once to use the same MAP dir and it caused other issues. I made a quick check with SMDs for example, looks like some are different and some same:

User@stevew /cygdrive/c/ko/ko/src/assets/server
$ sha256sum AIServer_MAP/battle_0516.smd
c1979b507feb711bbb10f3e44a6ab2fda697ae4034b7bff6859b87264317256c *AIServer_MAP/battle_0516.smd

User@stevew /cygdrive/c/ko/ko/src/assets/server
$ sha256sum Ebenezer_MAP/battle_0516.smd
c0cb23d1a5376361eaad9cc51c0f2da215bde3ffc33a850da6b9362634cedaeb *Ebenezer_MAP/battle_0516.smd

User@stevew /cygdrive/c/ko/ko/src/assets/server
$ sha256sum Ebenezer_MAP/free_0810.smd
704c9d68949414e23a370b69d169f5d89d8ab34c7b182e1ec8ea7177be722900 *Ebenezer_MAP/free_0810.smd

User@stevew /cygdrive/c/ko/ko/src/assets/server
$ sha256sum AIServer_MAP/free_0810.smd
704c9d68949414e23a370b69d169f5d89d8ab34c7b182e1ec8ea7177be722900 *AIServer_MAP/free_0810.smd

I think as next improvement cleaning up the current state of this project, is combining the two together, just to reduce resouces.

@GiRx8
Copy link
Contributor

GiRx8 commented Aug 8, 2022 via email

@stevewgr
Copy link
Member Author

stevewgr commented Aug 8, 2022

Why are the odbc connections being changed?

To keep this project's setup separate from existing configurations people already have. That way people don't have conflicts with their existing server setups. It will create less back and forth about common user errors where they ask us help, since it's separated from their existing setup.

@GiRx8
Copy link
Contributor

GiRx8 commented Aug 8, 2022

Why are the odbc connections being changed?

To keep this project's setup separate from existing configurations people already have. That way people don't have conflicts with their existing server setups. It will create less back and forth about common user errors where they ask us help, since it's separated from their existing setup.

ok! sounds good

@stevewgr
Copy link
Member Author

stevewgr commented Aug 8, 2022

@GiRx8, I created a ticket about the MAP dir situation: #76

@stevewgr stevewgr requested a review from GiRx8 August 8, 2022 19:19
@stevewgr stevewgr merged commit 03e8cc4 into master Aug 8, 2022
@stevewgr stevewgr deleted the working_dir branch August 8, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants