Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use crypto.timingSafeEqual for comparison #17

Closed
niftylettuce opened this issue Jul 29, 2018 · 6 comments
Closed

Use crypto.timingSafeEqual for comparison #17

niftylettuce opened this issue Jul 29, 2018 · 6 comments

Comments

@niftylettuce
Copy link
Contributor

jshttp/basic-auth#39
@haoxins
Copy link
Member

haoxins commented Jul 30, 2018

PR welcome :)

@niftylettuce
Copy link
Contributor Author

Just waiting on my PR to get accepted suryagh/tsscmp#7 and then I will submit PR from my work already done here https://github.com/niftylettuce/basic-auth.

@niftylettuce niftylettuce mentioned this issue Jul 31, 2018
Merged
@niftylettuce
Copy link
Contributor Author

PR made! @coderhaoxin

@niftylettuce
Copy link
Contributor Author

@coderhaoxin can you npm owner add niftylettuce koa-basic-auth?

@haoxins
Copy link
Member

haoxins commented Sep 3, 2018

@niftylettuce added :)

@niftylettuce
Copy link
Contributor Author

niftylettuce commented Sep 15, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niftylettuce @haoxins