-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add eslint-config, use only .travis.yml #31
Conversation
@sjmcdowall What is confusing me is that snyk report, as we already have all vulnerabilities fixed with |
also, we need to combine somehow this pr with other pr #30, maybe with the third branch? |
Is there a way to get the details of the synk errors? I'm not even sure how that pooch works.. Also, what's with the travis-ci failure? Do all those lint errors need to be fixed before we Merge? I think the things it flagged are spot on.. no issues with those! |
|
I would suggest merging #30 first, and then rebase this branch on master and fix all style stuff |
#30 merged.. |
e82a987
to
d679391
Compare
style: Apply eslint rules chore: Recreate package-lock
e188f62
to
0ddc5e0
Compare
@sjmcdowall |
Nice!! |
Motivation
Fixes #29
Changes