Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add eslint-config, use only .travis.yml #31

Merged
merged 1 commit into from
Oct 3, 2018

Conversation

oleg-koval
Copy link
Collaborator

Motivation

Fixes #29

Changes

  • use eslint, eslint-config-sexy rules
  • get rid of makefile, use .travis.yml instead

@oleg-koval
Copy link
Collaborator Author

@sjmcdowall
This is the initial push for new eslint rules, you can check all errors/warnings
After that, I 'll fix them all

What is confusing me is that snyk report, as we already have all vulnerabilities fixed with npm audit

@oleg-koval
Copy link
Collaborator Author

also, we need to combine somehow this pr with other pr #30, maybe with the third branch?

@sjmcdowall
Copy link
Contributor

sjmcdowall commented Oct 3, 2018

Is there a way to get the details of the synk errors? I'm not even sure how that pooch works..

Also, what's with the travis-ci failure? Do all those lint errors need to be fixed before we Merge?

I think the things it flagged are spot on.. no issues with those!

@oleg-koval
Copy link
Collaborator Author

@sjmcdowall

  • travis-ci shows what we need to fix regarding styling issues
  • snyk is minor problem, we can get to it later

@oleg-koval
Copy link
Collaborator Author

oleg-koval commented Oct 3, 2018

I would suggest merging #30 first, and then rebase this branch on master and fix all style stuff

@sjmcdowall
Copy link
Contributor

#30 merged..

style: Apply eslint rules

chore: Recreate package-lock
@oleg-koval
Copy link
Collaborator Author

@sjmcdowall
Looks like all fixed now finally :)

screenshot 2018-10-03 at 17 34 57

@sjmcdowall sjmcdowall merged commit 833387d into koajs:master Oct 3, 2018
@sjmcdowall
Copy link
Contributor

Nice!!

@oleg-koval oleg-koval deleted the oleg-koval/add-eslit-sexy branch October 3, 2018 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants