Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Remove unused variables #37

Merged
merged 2 commits into from
Feb 25, 2019
Merged

style: Remove unused variables #37

merged 2 commits into from
Feb 25, 2019

Conversation

oleg-koval
Copy link
Collaborator

No description provided.

@oleg-koval oleg-koval self-assigned this Feb 25, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1d68f63 on oleg-koval:style/remove-unused-variables into f8c95ae on koajs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1d68f63 on oleg-koval:style/remove-unused-variables into f8c95ae on koajs:master.

sjmcdowall
sjmcdowall approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@sjmcdowall sjmcdowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oleg-koval oleg-koval merged commit a1c22ab into koajs:master Feb 25, 2019
@oleg-koval oleg-koval deleted the style/remove-unused-variables branch February 25, 2019 12:31
@sjmcdowall
Copy link
Contributor

Don't forget to update the version # (2.1.1?) and History.md :)

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjmcdowall sjmcdowall sjmcdowall approved these changes

Assignees

@oleg-koval oleg-koval

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oleg-koval @coveralls @sjmcdowall