Pass this.req/this.res instead of this.request/this.response #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlai
force-pushed
the
standard-req-res
branch
from
76d56b1
to
7ec202c
Compare
This make the fields more consistent with other bunyan loggers and parsers, in particular having res._header have the response line instead of a header object. NOTE: this changes the format of the res object for request logging, including res.header and res.status (now res.statusCode)
jlai
force-pushed
the
standard-req-res
branch
from
7ec202c
to
6c98c3f
Compare
aheckmann
added a commit
that referenced
this pull request
Jan 23, 2015
Pass this.req/this.res instead of this.request/this.response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass this.req/this.res instead of this.request/this.response
This make the fields more consistent with other bunyan loggers
and parsers, in particular having res._header have the response
line instead of a header object.
NOTE: this changes the format of the res object for request
logging, including res.header and res.status (now res.statusCode)
Reviewer: @aheckmann