Use native promises

[lbeschastny]

No description provided.

[lbeschastny]

Actually, cash already use native promises.

But it also use .promisify and .coroutine from bluebird package.
Probably you meant that cash should get rid of those, to which I agree.

The former could be replaced with a simple inline implementation, while the later could be replaced with a co package (only in master branch since next use async/await instead).

Right now no one is actively working on this project, but I'll be happy to review a PR.

[nickmccurdy]

Yeah, I meant to suggest dropping the dependency on bluebird. I've been contributing to Koala but I might start a PR for this soon if I have time.

[nickmccurdy]

I'm trying to replace Bluebird.coroutine on master. Replacing the function with co gives me tons of test failures, I can post them if you're interested. However if I replace Bluebird.coroutine(function * ...) with just function * ... the tests pass. Is this valid or do we still need a coroutine implementation here?

[lbeschastny]

You've got a lot of errors because bluebirds's .coroutine does the same thing as co.wrap in co. So using just co(...) will break a lot of stuff.

[coveralls]

Coverage remained the same at 95.161% when pulling 5ea6bfb on bluebird-cleanup into 4977334 on master.

[lbeschastny]

Is this valid or do we still need a coroutine implementation here?

It's a very good observation.

Without co.wrap calling ctx.cashed will return a generator function instead of a promise, which is also yieldable. So, we don't really need any coroutibe wrapping here since koa already wraps everything with co.

[lbeschastny]

I think I'll keep co.wrap, because removing it may break someone's code.

[lbeschastny]

@nickmccurdy just published bluebird-free versions to npm:

{ latest: '2.2.0', next: '3.1.0-0' }

[nickmccurdy]

Perfect, thanks. I didn't think to try co.wrap.