yield*

[jonathanong]

use yield* internally. downstream must be a generator if it exists.

[jonathanong]

if we do this, then we have to use the function* (next) {} signature. it's no longer backwards compatible with function (next) { return function* () {} }

[tj]

hmm im seeing super minimal gains, ~100rps, not even worth breaking the old compat, a single console.log() does more damage than that

[jonathanong]

yeah, it's not a big deal, but it's an easy win and it helps people learn more about generators. after we change all our examples/middleware/tests to the new signature i don't think there's a reason to support the old signature.

hmmm. how about just making noop a generator for now? we can do the yield* next stuff later.

the end goal is to be able to do yield* next without worrying that next isn't a generator (otherwise it'll throw) and i like forcing middleware to being only a generator function.

[tj]

yeah I'd rather have yield next; than yield *next; any day

[jonathanong]

well it's interchangeable. as long as next is a generator it doesn't matter. you can decide which signature you want to use. i just don't want to worry about yield* next throwing.

[jonathanong]

i'm just gonna change noop to a generator function for now.