Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add variadic arg support #65

Merged
merged 3 commits into from
Oct 25, 2016
Merged

add variadic arg support #65

merged 3 commits into from
Oct 25, 2016

Conversation

stephenmathieson
Copy link
Contributor

ref #63

@codecov-io
Copy link

codecov-io commented Oct 22, 2016

Current coverage is 100% (diff: 100%)

Merging #65 into next will not change coverage

@@           next   #65   diff @@
=================================
  Files         1     1          
  Lines        18    19     +1   
  Methods       4     4          
  Messages      0     0          
  Branches      5     4     -1   
=================================
+ Hits         18    19     +1   
  Misses        0     0          
  Partials      0     0          

Powered by Codecov. Last update 755ab29...9177fb3

@stephenmathieson
Copy link
Contributor Author

Ping @jonathanong

@jonathanong
Copy link
Member

seems like you did this PR twice w/ #64 . which one should i look at? this one?

@stephenmathieson
Copy link
Contributor Author

Yep, I opened one against master and one against next. I only actually care about this one (next), but figured we should keep feature parity between both versions.

@jonathanong
Copy link
Member

ah i see. i wish the branch was more prominent

@jonathanong jonathanong merged commit f881413 into koajs:next Oct 25, 2016
@stephenmathieson
Copy link
Contributor Author

Yup, agreed. Thanks dude. Can you cut a release please (or add me and I'll do it)?

@stephenmathieson stephenmathieson deleted the next-varargs branch October 25, 2016 20:10
jonathanong added a commit that referenced this pull request Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants