Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazily flatten middleware #68

Closed
wants to merge 1 commit into from

Conversation

PlasmaPower
Copy link
Contributor

This is important as it allows for later modification, fixing a breaking change. Resolves #66, resolves #67.

This is important as it allows for later modification, fixing a breaking
change. Resolves koajs#66, resolves koajs#67.
@coveralls
Copy link

coveralls commented Oct 25, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 05158ca on PlasmaPower:lazy-flatten into 2276496 on koajs:master.

@jonathanong
Copy link
Member

why are you editing the middleware?

@PlasmaPower
Copy link
Contributor Author

I'm not, but we've already broken at least 3 user's programs. I think that can occur if you app.listen before you app.use. At this point we should either version it as a breaking change, revert it, or merge these PRs.

@PlasmaPower
Copy link
Contributor Author

Closing due to reverting variadic arguments instead. May be reopened in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

officially support mutating middleware Is 2.5.0 a breaking change?
3 participants