Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brotli used, even if not in Accept-Encoding header (v4.0.0) #107

Closed
Guillaume-Mayer opened this issue Apr 29, 2020 · 4 comments · Fixed by #109
Closed

Brotli used, even if not in Accept-Encoding header (v4.0.0) #107

Guillaume-Mayer opened this issue Apr 29, 2020 · 4 comments · Fixed by #109

Comments

@Guillaume-Mayer
Copy link

Sending Accept-Encoding: gzip, or Accept-Encoding: identity, if the response size is more than the threshold, the response get encoded with Brotli.

I used the default settings: app.use(compress());

I went back to 3.1.0 which works perfectly.

jonathanong added a commit that referenced this issue Apr 29, 2020
@jonathanong
Copy link
Member

895fbe8 these tests pass, can you make a PR with a failing test?

@Guillaume-Mayer
Copy link
Author

I will try to

@Guillaume-Mayer
Copy link
Author

It seems there is some state involved

@jonathanong
Copy link
Member

cool thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants