Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use lower case etag header #47

Closed
wants to merge 1 commit into from
Closed

refactor: use lower case etag header #47

wants to merge 1 commit into from

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Aug 21, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 53aa2d6 on lowercase-header-name into 79017e8 on master.

@jonathanong
Copy link
Member

did this break something?

@fengmk2
Copy link
Member Author

fengmk2 commented Aug 21, 2017

@jonathanong No, response.get(header) will always convert header to lower case. https://github.com/koajs/koa/blob/master/lib/response.js#L417

@3imed-jaberi 3imed-jaberi mentioned this pull request Sep 9, 2020
Merged
12 tasks
@niftylettuce
Copy link
Contributor

Can I please have npm ownership on this package? npm owner add niftylettuce koa-charset cc @jonathanong

@niftylettuce
Copy link
Contributor

v4.0.0 was just released https://github.com/koajs/etag/releases/tag/v4.0.0

@niftylettuce niftylettuce deleted the lowercase-header-name branch September 9, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanong jonathanong jonathanong approved these changes

@3imed-jaberi 3imed-jaberi 3imed-jaberi approved these changes

Assignees

@haoxins haoxins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fengmk2 @coveralls @jonathanong @niftylettuce @3imed-jaberi @haoxins