Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prolong session TTL on each request #76

Closed
catamphetamine opened this issue Jan 25, 2016 · 4 comments
Closed

prolong session TTL on each request #76

catamphetamine opened this issue Jan 25, 2016 · 4 comments

Comments

@catamphetamine
Copy link

Currently if a user browses a website but doesn't change his session data then the session times out.
I'm proposing this change to your library which fixes the issue:
catamphetamine@c7c13fc
catamphetamine@150d41e

It also prolongs session id http Cookie

@catamphetamine
Copy link
Author

The corresponding commit to koa-redis
@DaAwesomeP
catamphetamine/koa-redis@0f54069

@dead-horse
Copy link
Member

If you want to prelong session, why not turn options.rolling to true ?

@catamphetamine
Copy link
Author

But what does it do?
The documentation only says that rolling session, always reset the cookie and sessions, defaults to false.
I don't want my session to be reset on every request because the point of the session is to retain data in-between requests.

@evan-king
Copy link
Contributor

It does what you want (reset the timeout of session and cookie, not their actual contents) provided it won't be an issue that every request keeps the session alive (potentially including requests triggered by automated polling, which I'll bring up in another issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants