Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: user gets kicked off #45

Closed
iliakan opened this issue Apr 4, 2015 · 3 comments
Closed

Bug: user gets kicked off #45

iliakan opened this issue Apr 4, 2015 · 3 comments

Comments

@iliakan
Copy link
Contributor

iliakan commented Apr 4, 2015

Let's take a site with 15 mins session cookie timeout as an example.

Here's what happens:

  1. Bob gets a session.
  2. Bot interacts with the site without modifying the session. He does not get any cookie renewal because of that.
  3. After 15 minutes, Bob's cookie expires and he is kicked off.

Using rolling: true seems to prevent this (but resubmits whole session to db each time, not optimized).

But... the behavior is kind of strange, it seems natural that we don't want to kick out Bob while he's browsing the site. Maybe make session time-out on inactivity period by default?

@dead-horse
Copy link
Member

maybe we should set a logger exprie time like 1 day. and if Bob clicked _Remember me_, give him a much logger expire time in cookie's setting.

@catamphetamine
Copy link

@iliakan Ilya, have a look at my fix for this issue:
#76

@iliakan
Copy link
Contributor Author

iliakan commented Jan 25, 2016

@halt-hammerzeit it's not an issue for me any more, because of rolling:true and resaving session each time.

Maybe this was a question about making the behavior default or pushing it in the docs, cause it's kind of "what we used to want" :)

@iliakan iliakan closed this as completed Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants