Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koa-body should not blacklist body parsing on DELETE requests #133

Closed
katanacrimson opened this issue Feb 19, 2019 · 2 comments
Closed

koa-body should not blacklist body parsing on DELETE requests #133

katanacrimson opened this issue Feb 19, 2019 · 2 comments

Comments

@katanacrimson
Copy link
Contributor

koa-body should not blacklist DELETE method for body parsing.

Per RFC 7231 and the HTTP 1.1 specification, it is permitted to send a body with a DELETE request. In order to enable parsing of request bodies for DELETE methods, we have to wholesale disable strict mode, which means we're parsing it for GET and HEAD too - this is not a good solution.

@katanacrimson
Copy link
Contributor Author

Working on a PR which enables more granular selection of which methods body parsing should be used.

This will also result in a compatibility shim for strict mode, allowing its continued use, but would effectively deprecate it.

@doums
Copy link

doums commented Feb 27, 2019

I'm agree with you, it's just annoying that we can't use the body's request when using an http DELETE request..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants