Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typescript declaration files #56

Closed
naxmefy opened this issue May 31, 2017 · 9 comments
Closed

typescript declaration files #56

naxmefy opened this issue May 31, 2017 · 9 comments

Comments

@naxmefy
Copy link
Contributor

naxmefy commented May 31, 2017

could you create some?
@dlau
Copy link
Member

dlau commented May 31, 2017

Hi, yes typescript bindings would definitely be useful.

I'm a bit crushed with work at the moment-- I'll get to this when I have a chance. In the meantime feel free to submit a pr.

@weicracker
Copy link

https://github.com/weicracker/-types-koa-body

this is my using

@naxmefy
Copy link
Contributor Author

naxmefy commented Aug 17, 2017

@weicracker on https://github.com/weicracker/-types-koa-body/blob/master/index.d.ts#L41 you wrote onerror but it seems to be onError. Is this a problem?

@dlau I will add a PR for this issue

naxmefy added a commit to naxmefy/koa-body that referenced this issue Aug 17, 2017
@naxmefy
koajs#56 add TypeScript declaration file and add types property to pa…
1bca7c2 
…ckage.json

ignore package-lock.json
@naxmefy naxmefy mentioned this issue Aug 17, 2017
Merged
@blaesus
Copy link

blaesus commented Sep 17, 2017

@dlau @naxmefy How's the ts definition PR going through? I see the PR is a month-old now. Is there something I can help with?

@naxmefy
Copy link
Contributor Author

naxmefy commented Sep 25, 2017

@andyblaesus i dont know - @dlau have to merge it if he wants it

@dlau
Copy link
Member

dlau commented Sep 25, 2017

Sorry for the delay, merging!

dlau added a commit that referenced this issue Sep 25, 2017
@dlau
Merge pull request #65 from naxmefy/master
f97280e 
#56 add TypeScript declaration file
@dlau
Copy link
Member

dlau commented Sep 25, 2017

Live in 2.4.0

@dlau dlau closed this as completed Sep 25, 2017
@blaesus
Copy link

blaesus commented Sep 29, 2017

@dlau Hmm, when I npm install koa-body, I don't get the index.d.ts. I did get the 2.4.0 version though. Am I doing something wrong? Thanks!

@blaesus
Copy link

blaesus commented Oct 9, 2017

Never mind, it seems to work now. Thanks you for the efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@blaesus @dlau @naxmefy @weicracker