fix template not found #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -160,6 +160,12 @@ Hbs.prototype.createRenderer = function() { | |||
| var tplPath = hbs.getTemplatePath(tpl), | |||
| template, rawTemplate, layoutTemplate; | |||
|
|
|||
| if(tplPath === undefined) { | |||
| this.status = 500; | |||
There was a problem hiding this comment.
this isn't a pattern I'm familiar with koa-hbs using. personally think it'd be better to throw here than anything. status = 500 doesn't really mean anything, does it? only thing that comes to mind is an http 500 error, which wouldn't be 'not found'.
There was a problem hiding this comment.
@shellscape thank you for starting a discussion about this. I looked into this a bit more, and I agree with your suggestion. #42 is the tracking issue to utilize the standard koa error handling mechanisms.
There was a problem hiding this comment.
I meant to mention, there won't be a release with this change. There will be a new minor version once #42 closes.
|
Will be implementing a proper |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if template not found return status 500 template not found.