Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP/2 has no status message #1049

Merged
merged 3 commits into from Nov 6, 2017
Merged

Conversation

BernzSed
Copy link
Contributor

This change allows Koa to be used with Node's http2 module, introduced in Node 8.4.0, which you can use if you launch node with --expose-http2

@codecov
Copy link

codecov bot commented Aug 29, 2017

Codecov Report

Merging #1049 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1049   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files           5        5           
  Lines         369      369           
=======================================
  Hits          368      368           
  Misses          1        1
Impacted Files Coverage Δ
lib/response.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 392e8aa...d29136f. Read the comment docs.

@jonathanong
Copy link
Member

I believe there was an issue saying that node fixed this. anyone else know?

@dougwilson
Copy link
Contributor

Yes, fixed in Node.js and in 8.5

@BernzSed
Copy link
Contributor Author

Looks like it's fixed, but it emits a warning. So this PR isn't needed anymore, but it will prevent that warning, if you care about that.

@codecov-io
Copy link

codecov-io commented Sep 30, 2017

Codecov Report

Merging #1049 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1049   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files           5        5           
  Lines         369      369           
=======================================
  Hits          368      368           
  Misses          1        1
Impacted Files Coverage Δ
lib/response.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e81ea3...6d4330b. Read the comment docs.

@BernzSed BernzSed changed the title HTTP/2 has no status message (#1048) HTTP/2 has no status message Oct 25, 2017
@jonathanong jonathanong merged commit 6029064 into koajs:master Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants