Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: complete idempotent methods #274

Merged
merged 1 commit into from May 2, 2014

Conversation

yorkie
Copy link
Member

@yorkie yorkie commented May 2, 2014

see rfc2616: http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html#sec9.1.

Intact idempotent HTTP methods should be:
GET, HEAD, PUT, DELETE, OPTIONS and TRACE

And this should work based on visionmedia/node-methods? I'm not sure but sure that this should be clear at this module.
/cc @koajs

see rfc2616: http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html#sec9.1.

Intact idempotent HTTP methods should be:
GET, HEAD, PUT, DELETE, OPTIONS and TRACE
tj added a commit that referenced this pull request May 2, 2014
@tj tj merged commit 024b490 into koajs:master May 2, 2014
@tj
Copy link
Member

tj commented May 2, 2014

good call, thanks!

@yorkie yorkie deleted the complete-idempotent-methods branch May 2, 2014 19:21
@jonathanong
Copy link
Member

maybe we should just add this to methods? a utility like statuses would be nice

@tj
Copy link
Member

tj commented May 2, 2014

meh, doesn't matter to me, overkill either way, I'd never use it standalone but it wouldn't hurt

@yorkie
Copy link
Member Author

yorkie commented May 2, 2014

+1 for @jonathanong's idea.
But change the api of node-methods to do this has a big backward compatible problem :(
In other way, idempotent seems like a stuff belongs to HTTP, not HTTP METHODS.

@jonathanong
Copy link
Member

we could always attach properties to the array and make people very angry

@tj
Copy link
Member

tj commented May 2, 2014

haha it's really not worth any large amount of trouble

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants