99 params request ctx (#100)

* url params are part of the request and as such showed be part of the request object of koa (ctx.request.params) not just the ctx (ctx.params)

* resolves: #99 add additional test for subroutes

Co-authored-by: Trevor Pellegrini <trevor@Trevors-MacBook-Pro.local>

lib/router.js

@@ -362,7 +362,7 @@ Router.prototype.routes = Router.prototype.middleware = function () {
     layerChain = matchedLayers.reduce(function(memo, layer) {
       memo.push(function(ctx, next) {
         ctx.captures = layer.captures(path, ctx.captures);
-        ctx.params = layer.params(path, ctx.captures, ctx.params);
+        ctx.params = ctx.request.params = layer.params(path, ctx.captures, ctx.params);
         ctx.routerPath = layer.path;
         ctx.routerName = layer.name;
         ctx._matchedRoute = layer.path;

test/lib/router.js

@@ -851,6 +851,64 @@ describe('Router', function () {
     .expect('GET /users', done);
   });
 
+  it("parameter added to request in ctx", function (done) {
+      const app = new Koa();
+      const router = new Router();
+      router.get("/echo/:saying", function (ctx) {
+          try {
+            expect(ctx.params.saying).eql("helloWorld");
+            expect(ctx.request.params.saying).eql("helloWorld");
+            ctx.body = { echo: ctx.params.saying };
+          } catch(err) {
+            ctx.status = 500;
+            ctx.body = err.message;
+          }
+      });
+      app.use(router.routes());
+      request(http.createServer(app.callback()))
+          .get("/echo/helloWorld")
+          .expect(200)
+          .end(function (err, res) {
+            if (err) return done(err);
+              expect(res.body).to.eql({ echo: "helloWorld" });
+              done();
+          });
+  });
+
+  it("parameter added to request in ctx with sub router", function (done) {
+    const app = new Koa();
+    const router = new Router();
+    const subrouter = new Router();
+
+    router.use(function (ctx, next) {
+      ctx.foo = 'boo';
+      return next();
+    });
+
+    subrouter
+      .get('/:saying', function (ctx) {
+        try {
+          expect(ctx.params.saying).eql("helloWorld");
+          expect(ctx.request.params.saying).eql("helloWorld");
+          ctx.body = { echo: ctx.params.saying };
+        } catch(err) {
+          ctx.status = 500;
+          ctx.body = err.message;
+        }
+      });
+
+    router.use('/echo', subrouter.routes());
+    app.use(router.routes());
+    request(http.createServer(app.callback()))
+      .get('/echo/helloWorld')
+        .expect(200)
+        .end(function (err, res) {
+          if (err) return done(err);
+            expect(res.body).to.eql({ echo: "helloWorld" });
+            done();
+        });
+  });
+
   describe('Router#[verb]()', function () {
     it('registers route specific to HTTP verb', function () {
       const app = new Koa();