-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does this work with async/await? #26
Labels
Comments
PR welcomed!!! |
Forked and didn't make any changes but tests fail |
are you on windows? |
oh you're the same person. lol. #32 let me know if this works! |
menems
added a commit
to menems/send
that referenced
this issue
Oct 20, 2015
menems
added a commit
to menems/send
that referenced
this issue
Oct 21, 2015
menems
added a commit
to menems/send
that referenced
this issue
Oct 21, 2015
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Koa supports async functions, which is very useful for route definitions if you want to fetch some stuff from a database etc. But you have to use await inside the function. Since this doesn't return a promise, I can't await it... Why don't you make it return a promise? People could still yield it inside generator function middleware as they are automatically wrapped with co.
Example:
The text was updated successfully, but these errors were encountered: