Directories without a trailing slash #27 #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 9, 2015
|
Can we get this merged and pushed to npm? |
|
Looks good to me. |
|
@pierreburgy are you saying that this is ready to be patched, or that it should be working for me in production with an npm install? |
|
That is ready to patch. And I look forward, to see this fix on npm too ;) |
|
@pierreburgy +1 |
|
great! |
| @@ -187,6 +187,49 @@ describe('send(ctx, file)', function(){ | |||
| }) | |||
| }) | |||
|
|
|||
| describe('when path does not finish with slash and format is disabled', function(){ | |||
| it('should 200', function(done){ | |||
|
@coderhaoxin added you on npm. wanna merge and publish? |
|
ok! |
|
land bfd4cbc v2.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format the path to serve static file servers and not require a trailing slash for directories, so that you can do both /directory and /directory/.