New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert from generator to promise. #3
Conversation
@smcmurray Unit tests? |
@tejasmanohar yes. sorry about the unit tests. I'll try to get something there. |
@@ -1,7 +1,7 @@ | |||
{ | |||
"name": "koa-sendfile", | |||
"description": "basic file-sending utility for koa", | |||
"version": "1.1.1", | |||
"version": "1.2.0", | |||
"author": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, don't change the version in a PR.
@coderhaoxin thanks for the coaching |
oops. @smcmurray are you interested in maintaining this module? |
@jonathanong I need the right to publish this on npm, used this module in a project. |
@coderhaoxin can you remind me in 12 hours |
OK! |
added |
published |
@coderhaoxin, @jonathanong thanks for this. @jonathanong, I don't think I'd be the best maintainer. I'm flattered you would offer it. I'd love to take it and try, but you would have to babysit me anyway. So it might just make more work for you instead of less. |
No description provided.