Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert from generator to promise. #3

Closed
wants to merge 4 commits into from
Closed

Convert from generator to promise. #3

wants to merge 4 commits into from

Conversation

smcmurray
Copy link
Contributor

No description provided.

@tejasmanohar
Copy link
Member

@smcmurray Unit tests?

@smcmurray
Copy link
Contributor Author

@tejasmanohar yes. sorry about the unit tests.

I'll try to get something there.

@@ -1,7 +1,7 @@
{
"name": "koa-sendfile",
"description": "basic file-sending utility for koa",
"version": "1.1.1",
"version": "1.2.0",
"author": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, don't change the version in a PR.

@smcmurray
Copy link
Contributor Author

@coderhaoxin thanks for the coaching

@jonathanong jonathanong reopened this Feb 27, 2016
@jonathanong
Copy link
Member

oops.

@smcmurray are you interested in maintaining this module?

@haoxins haoxins closed this in 45d96d6 Feb 28, 2016
@haoxins
Copy link
Member

haoxins commented Feb 28, 2016

@jonathanong I need the right to publish this on npm, used this module in a project.

@jonathanong jonathanong self-assigned this Feb 28, 2016
@jonathanong
Copy link
Member

@coderhaoxin can you remind me in 12 hours

@haoxins
Copy link
Member

haoxins commented Feb 28, 2016

OK!

@jonathanong
Copy link
Member

added

@haoxins
Copy link
Member

haoxins commented Feb 29, 2016

published

@smcmurray
Copy link
Contributor Author

@coderhaoxin, @jonathanong thanks for this.

@jonathanong, I don't think I'd be the best maintainer. I'm flattered you would offer it.

I'd love to take it and try, but you would have to babysit me anyway. So it might just make more work for you instead of less.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants