Use CompletePackageInterface in test of package #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the resolution of bower dependecies, you merge rootPackages and the others packages (line 110) and test if package is an instance of CompletePackage.
But in the case where the root package uses an alias :
"branch-alias": { "dev-master": "2.0.x-dev" },
The type of package is
RootAliasPackage
which not extendCompletePackage
likeRootPackage
.So i think is better to check on an interface
CompletePackageInterface
to take all case