Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CompletePackageInterface in test of package #24

Merged
merged 1 commit into from
May 25, 2016

Conversation

alavieille
Copy link
Contributor

In the resolution of bower dependecies, you merge rootPackages and the others packages (line 110) and test if package is an instance of CompletePackage.

But in the case where the root package uses an alias :

"branch-alias": { "dev-master": "2.0.x-dev" },
The type of package is RootAliasPackage which not extend CompletePackage like RootPackage.

So i think is better to check on an interface CompletePackageInterface to take all case

@nsams nsams merged commit 9cce8d0 into koala-framework:master May 25, 2016
@nsams
Copy link
Member

nsams commented May 25, 2016

Thanks :)

@alavieille alavieille deleted the patch-1 branch May 25, 2016 14:57
@alavieille alavieille mentioned this pull request Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants