Fix check and assignment of orderId #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, orderId would have been a boolean (true) if $session->qentaCartId was set. This caused a problem with setCartOrderId($orderId) which translated "true" into "1" and getCartOrder() would then return the order with id 1 instead of the actual order.
kaufmo
reviewed
May 10, 2021
| if (!$orderId = $session->qentaCartId && isset($_POST['babytuch_orderId'])) { | ||
| if ($session->qentaCartId) { | ||
| $orderId = $session->qentaCartId; | ||
| } else if (isset($_POST['babytuch_orderId'])) { |
There was a problem hiding this comment.
why is there babytuch in the variable name ;)?
kaufmo
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, orderId would have been a boolean (true) if $session->qentaCartId
was set. This caused a problem with ::setCartOrderId($orderId) which translated
"true" into "1" and getCartOrder() would then return the order with id 1 instead
of the actual order.