Allow for ${@:2} syntax in variable assignment

[DocSalvager]

Nice tool! Plan to use it.

But my first experiment revealed it needs a bit of tweaking. Did not allow for the valid syntax in a working script as described below...

In the output below, local _help_text="${@:2}" concatenates the function's positional arguments 2 and greater into a string and assigns them to the variable $_help_text...

48      local _help_text="${@:2}"`
                           ^––SC2124 Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.

[dualbus]

Well, you indeed have to use ${:2}, more specifically, IFS=' '; echo
"${:2}"

The fact that the @ variant works is just really because shell is a mess,
but technically, the @ variant fails in many contexts.

So, shellcheck is right, use * to concatenate an array, and @ to expand the
array to its elements.

On Thu, Aug 14, 2014 at 7:33 PM, DocSalvage notifications@github.com
wrote:

Nice tool! Plan to use it.

But my first experiment revealed it needs a bit of tweaking. Did not allow
for the valid syntax in a working script as described below...

In the output below, local _help_text="${@:2}" concatenates the
function's positional arguments 2 and greater into a string and assigns
them to the variable $_help_text...

48 local _help_text="${@:2}"`
^––SC2124 Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.

—
Reply to this email directly or view it on GitHub
#214.

[koalaman]

dualbus is right, this is a valid warning.

The behavior you're relying on is undefined and often associated with bugs. Scripts would be better off using the explicitly concatenating form.

[evandrocoan]

Related to:

1. "$@" serves a purpose, no? #1148 "$@" serves a purpose, no?
2. SC2048 is overly zealous #127 SC2048 is overly zealous

See also How to portability use "${@:2}"?