sklearn update fix #134
Merged
sklearn update fix #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MBrouns
approved these changes
May 14, 2019
|
this one was actually sensible. but there's something else going on on master. |
|
readme change caused a red dot. might be a version thing. |
|
ah. scikit-learn recently upgraded. that seems to cause the error ... ... we might need to test against multiple versions :( |
|
@CorXccelerated just a heads up, this seems to affect the debug pipeline. |
|
so ... to me it seems like the testing for the debug pipeline is due for a bit of a revamp. the tests are super long. it does seem like some of the standard error messages out of scikit learn have changed. |
|
@MBrouns @CorXccelerated i don't suppose tomorrow y'all are going to be hacking on this :) ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.