Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] add repeating and spanning basis functions #147

Closed

Conversation

RensDimmendaal
Copy link
Contributor

@RensDimmendaal RensDimmendaal commented May 31, 2019

I'm building preprocessing functions to address:
#20
#29

Open Issues:

  1. RepeatingBasisFeatures currently accepts only one feature. This is problematic for most tests.

@kayhoogland
Copy link
Contributor

Any updates on this @RensDimmendaal? Would love to use it!

@RensDimmendaal
Copy link
Contributor Author

Far point. I have left this to sit for too long. It is unclear to me how to run the standard tests this because transformer only accepts one column. @koaning mentioned the idea of wrapping the transformer with a column selector for the tests. I'll try that in the next 7 days.

@MBrouns
Copy link
Collaborator

MBrouns commented Jul 26, 2019

Wrapping the thing in a columntransformer is probably a reasonable default anyway! Basically something like this

class RepeatingBasisFunction:
    def __init__(column, *args, **kwargs):
        return ColumnTransformer([
            ('repeatingbasis', _RepeatingBasisFunction(*args, **kwargs), column)
        ], remainder='passthrough')

class _RepeatingBasisFunction:
    pass # Your current implementation

@RensDimmendaal
Copy link
Contributor Author

Continued in a different branch #171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants