Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for #158 #159

Merged
merged 13 commits into from
Jul 25, 2019
Merged

Bugfix for #158 #159

merged 13 commits into from
Jul 25, 2019

Commits on Jul 3, 2019

  1. Add test with column of strings as groups

    @pim-hoeven
    pim-hoeven committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    51241c6 View commit details
    Browse the repository at this point in the history

  2. Fixed bug in grouped estimator using string column as grouping variable

    @pim-hoeven
    pim-hoeven committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    afffefb View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into 158-string-values-as-group

    @koaning
    koaning committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    4766672 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into 158-string-values-as-group

    @pim-hoeven
    pim-hoeven committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    17f6b70 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2019

  1. Proposed fix for the remarks

    @pim-hoeven
    pim-hoeven committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    7103101 View commit details
    Browse the repository at this point in the history

  2. Merge branch '158-string-values-as-group' of github.com:pim-hoeven/sc… 

    …ikit-lego into 158-string-values-as-group
    @pim-hoeven
    pim-hoeven committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    ca9e5fe View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into 158-string-values-as-group

    @pim-hoeven
    pim-hoeven committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    8f0a918 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2019

  1. Added some comments

    @pim-hoeven
    pim-hoeven committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    0f6dcb5 View commit details
    Browse the repository at this point in the history

  2. Merge branch '158-string-values-as-group' of github.com:pim-hoeven/sc… 

    …ikit-lego into 158-string-values-as-group
    @pim-hoeven
    pim-hoeven committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    e099b67 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into 158-string-values-as-group

    @koaning
    koaning committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    54abb09 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2019

  1. Changed try-except to isinstance checks

    @pim-hoeven
    pim-hoeven committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    7a82b98 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2019

  1. Merge branch 'master' into 158-string-values-as-group

    @koaning
    koaning committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    a027ce6 View commit details
    Browse the repository at this point in the history

  2. Added some more comments

    @pim-hoeven
    pim-hoeven committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    49d99b6 View commit details
    Browse the repository at this point in the history