Omit empty group labels when generating XML #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goal: make formpack-to-XML conversion behave the same way as formpack-to-XLSForm-to-XML conversion. The better those match, the better KPI's previews will match its deployed forms. In this particular case, pyxform discarded empty cells when loading from XLSForm, but formpack was preserving empty strings when sending Python structures to pyxform for conversion to XML. One consequence of this was empty translated labels being shown for groups in KPI previews, i.e. kobotoolbox/kpi#2707.
|
Coverage increased (+0.3%) to 84.133% when pulling 2af00be on kobotoolbox/kpi#2707-omit-empty-group-labels into 2d68ce0 on master. |
This was referenced Dec 3, 2020
|
I tested this branch and it looks good and behaves as it should. 👍 |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: make formpack-to-XML conversion behave the same way as
formpack-to-XLSForm-to-XML conversion. The better those match, the
better KPI's previews will match its deployed forms.
In this particular case, pyxform discarded empty cells when loading from
XLSForm, but formpack was preserving empty strings when sending Python
structures to pyxform for conversion to XML. One consequence of this was
empty translated labels being shown for groups in KPI previews, i.e.
kobotoolbox/kpi#2707.