Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the strings in the export settings for a project #4646

Open
JacquelineMorrissette opened this issue Sep 19, 2023 · 1 comment · Fixed by #4656
Open

Fix the strings in the export settings for a project #4646

JacquelineMorrissette opened this issue Sep 19, 2023 · 1 comment · Fixed by #4656
Assignees
Labels
enhancement Ideas, improvements and features Front end

Comments

@JacquelineMorrissette
Copy link
Contributor

Currently, the wording for exports is confusing. Include data from all {int} versions implies that only the submissions for the current version will be exported if the box is unchecked and I propose we change it to Include fields from all {int} versions for clarity.

While we are at it, we should change the string to make the whole phrase one string in the code because it splits the strings for translators who view it as two separate phrases.

Current String: Include data from all {int} versions
Expected String: Include fields from all {int} versions

image

renderAdvancedView() {
const includeAllVersionsLabel = (
<span>
{t('Include data from all')}
&nbsp;
<strong>{this.props.asset.deployed_versions.count}</strong>
&nbsp;
{t('versions')}
</span>
);

@JacquelineMorrissette
Copy link
Contributor Author

Assigned to @magicznyleszek for deligation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Ideas, improvements and features Front end
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants