Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement store as part of the hub #316

Merged
merged 2 commits into from
May 2, 2022
Merged

Conversation

axdotl
Copy link
Contributor

@axdotl axdotl commented Apr 29, 2022

This PR adds the store implementation which becomes part of the hub.

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022

Codecov Report

Merging #316 (a05393c) into rework-kobs-architecture (371ca2f) will increase coverage by 0.31%.
The diff coverage is 47.69%.

@@                     Coverage Diff                      @@
##           rework-kobs-architecture     #316      +/-   ##
============================================================
+ Coverage                     44.38%   44.70%   +0.31%     
============================================================
  Files                            45       46       +1     
  Lines                          2431     2691     +260     
============================================================
+ Hits                           1079     1203     +124     
- Misses                         1333     1426      +93     
- Partials                         19       62      +43     
Impacted Files Coverage Δ
pkg/hub/store/store.go 47.69% <47.69%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 371ca2f...a05393c. Read the comment docs.

@axdotl axdotl merged commit 3e8982c into rework-kobs-architecture May 2, 2022
@axdotl axdotl deleted the implement-store branch May 2, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants