Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework kobs architecture add dashboards #329

Merged

Conversation

ricoberger
Copy link
Member

@ricoberger ricoberger changed the base branch from main to rework-kobs-architecture May 31, 2022 18:04
@ricoberger ricoberger force-pushed the rework-kobs-architecture-add-dashboards branch from c5b9a78 to bc6e686 Compare May 31, 2022 18:08
@codecov-commenter
Copy link

Codecov Report

Merging #329 (bc6e686) into rework-kobs-architecture (e00fe61) will decrease coverage by 0.29%.
The diff coverage is 44.91%.

@@                     Coverage Diff                      @@
##           rework-kobs-architecture     #329      +/-   ##
============================================================
- Coverage                     49.47%   49.17%   -0.30%     
============================================================
  Files                            61       69       +8     
  Lines                          3493     4539    +1046     
============================================================
+ Hits                           1728     2232     +504     
- Misses                         1716     2251     +535     
- Partials                         49       56       +7     
Impacted Files Coverage Δ
cmd/kobs/hub/hub.go 20.51% <0.00%> (-0.41%) ⬇️
cmd/kobs/satellite/satellite.go 14.66% <0.00%> (-0.62%) ⬇️
packages/plugin-prometheus/cmd/prometheus.go 0.00% <0.00%> (ø)
packages/plugin-prometheus/pkg/instance/helpers.go 0.00% <0.00%> (ø)
...ackages/plugin-prometheus/pkg/instance/instance.go 0.00% <0.00%> (ø)
pkg/app/app.go 0.00% <0.00%> (ø)
pkg/hub/api/plugins/plugins.go 0.00% <0.00%> (ø)
pkg/hub/hub.go 0.00% <0.00%> (ø)
pkg/hub/store/shared/satellite.go 92.15% <0.00%> (-7.85%) ⬇️
pkg/middleware/basicauth/basicauth.go 0.00% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e00fe61...bc6e686. Read the comment docs.

@ricoberger ricoberger merged commit 8ccf65b into rework-kobs-architecture May 31, 2022
@ricoberger ricoberger deleted the rework-kobs-architecture-add-dashboards branch May 31, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants