Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[app] Update Permission Handling #348

Merged
merged 2 commits into from
Jun 13, 2022
Merged

[app] Update Permission Handling #348

merged 2 commits into from
Jun 13, 2022

Conversation

ricoberger
Copy link
Member

@ricoberger ricoberger commented Jun 13, 2022

We have updated the CRDs to have a better permission handling when the
kobs hub component is started with the "--auth.enabled" flag. In detail
we did the following changes:

  • Do not require all fields in the User / Team permissions
  • Check the plugin type. Until now we only checked the satellite and
    name of a plugin, but not the plugin type.
  • Adjust cookie settings (include path and expire date).

@ricoberger ricoberger changed the title Update CRDs Update CRDs for Permission Handling Jun 13, 2022
We have updated the CRDs to have a better permission handling when the
kobs hub component is started with the "--auth.enabled" flag. In detail
we did the following changes:

- Do not require all fields in the User / Team permissions
- Check the plugin type. Until now we only checked the satellite and
  name of a plugin, but not the plugin type.
- Adjust cookie settings (include path and expire date).
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2022

Codecov Report

Merging #348 (998f3fd) into main (ff926a2) will decrease coverage by 0.01%.
The diff coverage is 38.46%.

❗ Current head 998f3fd differs from pull request most recent head 504ef57. Consider uploading reports for the commit 504ef57 to get more accurate results

@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
- Coverage   46.22%   46.20%   -0.02%     
==========================================
  Files         126      126              
  Lines        9054     9068      +14     
==========================================
+ Hits         4185     4190       +5     
- Misses       4783     4792       +9     
  Partials       86       86              
Impacted Files Coverage Δ
pkg/hub/api/plugins/plugins.go 0.00% <0.00%> (ø)
pkg/hub/hub.go 0.00% <0.00%> (ø)
pkg/satellite/plugins/plugins.go 0.00% <0.00%> (ø)
pkg/hub/middleware/userauth/auth.go 100.00% <100.00%> (ø)
pkg/hub/middleware/userauth/context/context.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7825a7...504ef57. Read the comment docs.

@ricoberger ricoberger changed the title Update CRDs for Permission Handling Update Permission Handling Jun 13, 2022
@ricoberger ricoberger marked this pull request as ready for review June 13, 2022 21:11
@ricoberger ricoberger merged commit 676c646 into main Jun 13, 2022
@ricoberger ricoberger deleted the update-crds branch June 13, 2022 21:12
@ricoberger ricoberger changed the title Update Permission Handling [app] Update Permission Handling Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants