[app] Fix Permission Handling for Apps and Teams #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug in the permission handling for applications and teams. Because we not only checked the "all" query parameter in the corresponding routes, it could happen that we return all applications / teams, when a user just wants to see his own applications / teams. We are now just checking if the "all" query parameter is true to set the teams to "nil". For all other use cases we are directly using the teams form the authenticated user object. When authentication is disabled or when no team header is present the teams for the user are automatically set to "nil" so that the other checks are not necessary anymore.
ricoberger
deleted the
fix-permission-handling-for-applications-and-teams
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in the permission handling for applications and
teams. Because we not only checked the "all" query parameter in the
corresponding routes, it could happen that we return all applications /
teams, when a user just wants to see his own applications / teams.
We are now just checking if the "all" query parameter is true to set the
teams to "nil". For all other use cases we are directly using the teams
form the authenticated user object.
When authentication is disabled or when no team header is present the
teams for the user are automatically set to "nil" so that the other
checks are not necessary anymore.