Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[app] Fix Shutdown Logic #396

Merged
merged 1 commit into from
Jul 18, 2022
Merged

[app] Fix Shutdown Logic #396

merged 1 commit into from
Jul 18, 2022

Conversation

ricoberger
Copy link
Member

We forgot to shutdown the created tracer provider. This is now
implemented, by returning a client in the tracer setup. This client
exposes a Shutdown method which can be used to gracefully shutdown the
tracer provider.

We also fixed the context timeouts for all http server, so that the hub,
satellite and app server are having a timeout of 30 seconds and the
metrics server has a timeout of 10 seconds as it is also used for the
tracer client.

This way we always stay within the 90 seconds timeout, which was
configured at the Kubernetes deployments for the hub and satellite.

@codecov-commenter
Copy link

Codecov Report

Merging #396 (2ae909e) into main (a8a71d8) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
- Coverage   45.43%   45.35%   -0.08%     
==========================================
  Files         134      134              
  Lines       10435    10452      +17     
==========================================
  Hits         4741     4741              
- Misses       5614     5631      +17     
  Partials       80       80              
Impacted Files Coverage Δ
cmd/kobs/hub/hub.go 0.00% <0.00%> (ø)
cmd/kobs/satellite/satellite.go 0.00% <0.00%> (ø)
pkg/app/app.go 0.00% <0.00%> (ø)
pkg/hub/hub.go 0.00% <0.00%> (ø)
pkg/metrics/metrics.go 0.00% <0.00%> (ø)
pkg/satellite/satellite.go 0.00% <0.00%> (ø)
pkg/tracer/tracer.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8a71d8...2ae909e. Read the comment docs.

We forgot to shutdown the created tracer provider. This is now
implemented, by returning a client in the tracer setup. This client
exposes a Shutdown method which can be used to gracefully shutdown the
tracer provider.

We also fixed the context timeouts for all http server, so that the hub,
satellite and app server are having a timeout of 30 seconds and the
metrics server has a timeout of 10 seconds as it is also used for the
tracer client.

This way we always stay within the 90 seconds timeout, which was
configured at the Kubernetes deployments for the hub and satellite.
@ricoberger ricoberger merged commit 4762ab5 into main Jul 18, 2022
@ricoberger ricoberger deleted the fix-shutdown-logic branch July 18, 2022 15:39
@ricoberger ricoberger added the changelog: fixed Something which wasn't working is fixed label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: fixed Something which wasn't working is fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants