Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[app] Add recover handler for metrics middleware #400

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

ricoberger
Copy link
Member

We now have a recover handler for the "httpmetrics" middleware. We also
renamed the metrics to "kobs_requests_total",
"kobs_request_duration_seconds" and "kobs_request_size_bytes".

We now have a recover handler for the "httpmetrics" middleware. We also
renamed the metrics to "kobs_requests_total",
"kobs_request_duration_seconds" and "kobs_request_size_bytes".
@codecov-commenter
Copy link

Codecov Report

Merging #400 (8a6e8b4) into main (03b01a9) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
- Coverage   45.87%   45.84%   -0.03%     
==========================================
  Files         137      137              
  Lines       10634    10640       +6     
==========================================
  Hits         4878     4878              
- Misses       5671     5677       +6     
  Partials       85       85              
Impacted Files Coverage Δ
pkg/middleware/httpmetrics/httpmetrics.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@ricoberger ricoberger merged commit 3ec93d2 into main Jul 22, 2022
@ricoberger ricoberger deleted the app-recover-metrics branch July 22, 2022 13:10
@ricoberger ricoberger added the changelog: changed Something was changed or updated label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: changed Something was changed or updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants