[app] Imporove federated module core #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marwonline
force-pushed
the
app-fed-mod-refactoring
branch
2 times, most recently
from
89606a3
to
67ba10a
Compare
marwonline
force-pushed
the
app-fed-mod-refactoring
branch
from
67ba10a
to
8c287d5
Compare
marwonline
commented
Jul 31, 2022
| * @param scope the module scope. In kobs it's usually the plugin name: e.g. 'kiali' | ||
| * @param module the name of the module entry point. e.g. './Page' | ||
| * @returns the module component or method | ||
| */ |
There was a problem hiding this comment.
Added some documentation. In a later PR, I'll try to type this with generics so that we can get rid of any.
| } | ||
|
|
||
| if (failed) { | ||
| if (isFailed) { |
There was a problem hiding this comment.
I've re-ordered the cases so that the error case always apprears first.
| * Note: the version can't be changed during runtime. | ||
| * @returns the status of the script/module | ||
| */ | ||
| export const useDynamicScript = (name: string, version: string): ScriptStatus => { |
There was a problem hiding this comment.
I've separated the Kobs business logic and the script loading into two functions. Should make it easier to re-use it later
ricoberger
approved these changes
Jul 31, 2022
There was a problem hiding this comment.
Hi @marwonline and thanks for your contribution.
I tested your changes locally and everything works as expected 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactoring of the module federation handling which is used to load/handle/initialize plugins