Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[app] Fix error handling in resources table #416

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

ricoberger
Copy link
Member

This commit fixes the error handling in the resources table. When an
error was returned and a valid list of resources, we did not show the
list, but instead we only show the errors.

Now we are checking if there is a valid list of resources. If this is
the case we render the table and ignore the errors.

We also fixed the handling of links in notification. Until now we always
displayed an external link icon which was used to redirect a user to the
details. Now the user can directly click on the notification to get
redirected to the details for a notification.

This commit fixes the error handling in the resources table. When an
error was returned and a valid list of resources, we did not show the
list, but instead we only show the errors.

Now we are checking if there is a valid list of resources. If this is
the case we render the table and ignore the errors.

We also fixed the handling of links in notification. Until now we always
displayed an external link icon which was used to redirect a user to the
details. Now the user can directly click on the notification to get
redirected to the details for a notification.
@codecov-commenter
Copy link

Codecov Report

Merging #416 (6ca74e5) into main (bbf3ac8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #416   +/-   ##
=======================================
  Coverage   46.35%   46.35%           
=======================================
  Files         139      139           
  Lines       11776    11776           
=======================================
  Hits         5459     5459           
  Misses       6176     6176           
  Partials      141      141           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ricoberger ricoberger merged commit cad3c1f into main Aug 22, 2022
@ricoberger ricoberger deleted the app-fix-error-handling-in-resources-table branch August 22, 2022 20:18
@ricoberger ricoberger added the changelog: fixed Something which wasn't working is fixed label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: fixed Something which wasn't working is fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants