Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[app] Rework "useDimensions" hook #422

Merged
merged 1 commit into from
Aug 28, 2022
Merged

Conversation

ricoberger
Copy link
Member

We changed the "useDimensions" hook, so that the hook now also takes
into account when the sidebar is toggled. Before the rework the returned
height and width of the "useDimensions" hook was not changed when a user
opens/closes the sidebar, so that some components where not correctly
adjusted. This is now fixed by using the "getResizeObserver" from the
"@patternfly/react-charts" package within the hook.

We changed the "useDimensions" hook, so that the hook now also takes
into account when the sidebar is toggled. Before the rework the returned
height and width of the "useDimensions" hook was not changed when a user
opens/closes the sidebar, so that some components where not correctly
adjusted. This is now fixed by using the "getResizeObserver" from the
"@patternfly/react-charts" package within the hook.
@codecov-commenter
Copy link

Codecov Report

Merging #422 (1529ccf) into main (d89ca1e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #422   +/-   ##
=======================================
  Coverage   45.61%   45.61%           
=======================================
  Files         139      139           
  Lines       11892    11892           
=======================================
  Hits         5425     5425           
  Misses       6328     6328           
  Partials      139      139           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ricoberger ricoberger merged commit 84a5131 into main Aug 28, 2022
@ricoberger ricoberger deleted the app-rework-usedimensions-hook branch August 28, 2022 15:00
@ricoberger ricoberger added the changelog: changed Something was changed or updated label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: changed Something was changed or updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants