Fix logging related warnings #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, I know my fix was a dirty one, but needed it back as one of the modules was using it to display messages. Wanted to pick up later, but thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the first "" from the
SQINFOarguments. A new__FUNCTION__argument was added to the Rack2 logger, adding the "" to the Squinky logger caused the number of arguments to match, so it compiled and passed "" as the function name, but the correct fix I think is to update theSQINFOmacro so that__FUNCTION__is passed.Fixed all logging related warnings on Ubuntu and Windows.
The only warning I see now is the following, which is in the Rack v2 code base: