Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide prices from UI #1585

Closed
yangwao opened this issue Dec 22, 2021 · 4 comments · Fixed by #1624
Closed

Hide prices from UI #1585

yangwao opened this issue Dec 22, 2021 · 4 comments · Fixed by #1624
Assignees
@prachi00
Labels
$ ~<50usd A-nuxt p4 affecting less than 10% of app

Comments

@yangwao
Copy link
Member

yangwao commented Dec 22, 2021 •
edited
Loading

Part of user preference issue
#942 #1581

Hide prices at gallery view (by default?)
Collection view &c
@yangwao yangwao added $ ~<50usd A-nuxt labels Dec 22, 2021
@prachi00
Copy link
Member

@yangwao I'll try to do this

@yangwao
Copy link
Member Author

yangwao commented Dec 22, 2021

Let's try! I'm plan to do following issue after merging recent PR creating user preference screen @kkukelka and it could be easily done :)

@prachi00
Copy link
Member

@yangwao hiding prices in gallery and collection view should be different checkbox options or combined in one in user preferences?

@yangwao
Copy link
Member Author

yangwao commented Dec 27, 2021

@yangwao hiding prices in gallery and collection view should be different checkbox options or combined in one in user preferences?

Probably could be one for now for easier way to do

@yangwao yangwao added the p4 affecting less than 10% of app label Dec 27, 2021
prachi00 added a commit to prachi00/nft-gallery that referenced this issue Dec 28, 2021
@prachi00
kodadot#1585 Hiding from collection views
62d84a6
@prachi00 prachi00 mentioned this issue Dec 28, 2021
Merged
16 tasks
yangwao added a commit that referenced this issue Dec 29, 2021
@yangwao
Merge pull request #1624 from prachi00/feat-user-pref-hide-price
184e14e 
#1585 Hide prices from UI
@yangwao yangwao mentioned this issue Jan 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prachi00 prachi00

Labels
$ ~<50usd A-nuxt p4 affecting less than 10% of app
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1585 Hide prices from UI prachi00/nft-gallery
2 participants
@yangwao @prachi00