Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep only top-border on pagination and sharing buttons #2578

Closed
yangwao opened this issue Mar 17, 2022 · 1 comment · Fixed by #2580
Closed

Keep only top-border on pagination and sharing buttons #2578

yangwao opened this issue Mar 17, 2022 · 1 comment · Fixed by #2580
Labels
$ ~<50usd p2 core functionality, or is affecting 60% of app

Comments

@yangwao
Copy link
Member

yangwao commented Mar 17, 2022 •
edited
Loading

  • Keep only top-border on pagination buttons

Probably reflect everywhere where we are using pagination

  • gallery
  • collections
  • artists profile
  • collection detail

image

image

On collection detail like at https://beta.kodadot.xyz/rmrk/collection/0a8ce195286c168f19-DONKEY?tab=collection

  • Keep only top-border on sharing and make it 1px

image

For item action buttons and sharing do the same 🥺
image
@yangwao yangwao added $ ~<50usd p2 core functionality, or is affecting 60% of app labels Mar 17, 2022
@prachi00
Copy link
Member

@yangwao I'll do this

prachi00 added a commit to prachi00/nft-gallery that referenced this issue Mar 17, 2022
@prachi00
kodadot#2578 Keep only top-border on pagination and sharing buttons
3019b3b
@prachi00 prachi00 mentioned this issue Mar 17, 2022
Merged
16 tasks
@yangwao yangwao mentioned this issue Mar 20, 2022
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
$ ~<50usd p2 core functionality, or is affecting 60% of app
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2578 Keep only top-border on pagination and sharing buttons prachi00/nft-gallery
2 participants
@yangwao @prachi00