Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor History component #2589

Closed
vikiival opened this issue Mar 19, 2022 · 17 comments · Fixed by #3025
Closed

Refactor History component #2589

vikiival opened this issue Mar 19, 2022 · 17 comments · Fixed by #3025
Assignees
Labels
$ ~<50usd enhancement New feature or request p3 non-core, affecting less than 40%

Comments

@vikiival
Copy link
Member

vikiival commented Mar 19, 2022

Is your feature request related to a problem?

The code looks supper messy, and It's tough to read

Describe the solution you would like

  • Clean up the code.
  • Make it more component friendly (aka reusable)

Describe alternatives you have considered

ref #2551

This issue is currently blocked by kodadot/rubick#40
We need to save the current owner of the NFT when the event has happened

@vikiival vikiival added the enhancement New feature or request label Mar 19, 2022
@vikiival
Copy link
Member Author

also this

['all', '🤝 BUY', '🎁 GIFT']

needs to be done smarter

@Jarsen136
Copy link
Contributor

Hello, I will have a try.

@vikiival
Copy link
Member Author

@Jarsen136 hey this is not an urgent issue, please check issues with p2 label

like #2329

@yangwao yangwao added $ ~<50usd p4 affecting less than 10% of app labels Mar 22, 2022
@vikiival
Copy link
Member Author

Also there are some odd hacks with timestamps as id (#2654)

@yangwao yangwao added p3 non-core, affecting less than 40% and removed p4 affecting less than 10% of app labels May 8, 2022
@Jarsen136
Copy link
Contributor

I will take this

@kodabot
Copy link
Collaborator

kodabot commented May 15, 2022

ISSUE BLOCKED - issue #2589 is blocked. Please wait until issue is unblocked.

@vikiival
Copy link
Member Author

@Jarsen136 please try again :)

@Jarsen136
Copy link
Contributor

I will take this

@Jarsen136
Copy link
Contributor

I seem to find the edge case of the assign bot

@vikiival
Copy link
Member Author

vikiival commented May 15, 2022

Spawning @petersopko 🦅

@petersopko
Copy link
Contributor

hmm, let me try

@petersopko
Copy link
Contributor

I will take this

@kodabot
Copy link
Collaborator

kodabot commented May 15, 2022

ASSIGNED - @petersopko 🔒 LOCKED -> Monday, May 16th 2022, 21:08:41 UTC -> 36 hours

@petersopko
Copy link
Contributor

Spawning @petersopko 🦅

not sure what happened here, but just talked with @yangwao, we're gonna simplify the assigning process, i.e. remove all of the goPhrases and set it universally just to 👋 -> :wave:.
Maybe it wasn't the problem here, but I can't see in logs why wouldn't the bot assign @Jarsen136

@petersopko petersopko removed their assignment May 15, 2022
@kodabot
Copy link
Collaborator

kodabot commented May 15, 2022

ASSIGNMENT OVER - @petersopko has been unassigned.

@kodabot
Copy link
Collaborator

kodabot commented May 15, 2022

ASSIGNED - @Jarsen136 🔒 LOCKED -> Monday, May 16th 2022, 21:15:44 UTC -> 36 hours

@vikiival
Copy link
Member Author

not sure what happened here, but just talked with @yangwao, we're gonna simplify the assigning process, i.e. remove all of the goPhrases and set it universally just to 👋 -> :wave:.

Perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd enhancement New feature or request p3 non-core, affecting less than 40%
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

5 participants