Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort in gallery broken #3266

Closed
petersopko opened this issue Jun 24, 2022 · 8 comments · Fixed by #3325 or #3442
Closed

sort in gallery broken #3266

petersopko opened this issue Jun 24, 2022 · 8 comments · Fixed by #3325 or #3442
Labels
$ ~<50usd 🧙‍♀️ - bug-hunt bug Something isn't working p1 preventing everyone from using app

Comments

@petersopko
Copy link
Contributor

petersopko commented Jun 24, 2022

//edit:

sort still needs fine tuning, while the conflicting params don't get passed in at once anymore, it still seems that the sort is not executing correctly (i.e. if you sort for price and then recently interacted, it takes the first argument but not the second one)

It seems that on beta, with the newest changes, we lost sort. Currently, picking one of the sort options just adds the parameters to the URL i.e.: https://beta.kodadot.xyz/rmrk/explore?page=1&tab=GALLERY&sort=BLOCK_NUMBER_DESC&sort=UPDATED_AT_ASC&sort=UPDATED_AT_DESC

image

@petersopko petersopko added bug Something isn't working $ ~<50usd p1 preventing everyone from using app 🧙‍♀️ - bug-hunt labels Jun 24, 2022
@prachi00
Copy link
Member

👋

@kodabot
Copy link
Collaborator

kodabot commented Jun 24, 2022

ASSIGNED - @prachi00 🔒 LOCKED -> Sunday, June 26th 2022, 07:34:46 UTC -> 36 hours

@prachi00
Copy link
Member

seems to work fine in local 🤔

@petersopko
Copy link
Contributor Author

petersopko commented Jun 25, 2022

seems to work fine in local 🤔

After pulling latest pain main, same thing on local for me
image

@prachi00
Copy link
Member

seems to work fine in local 🤔

After pulling latest pain main, same thing on local for me
image

Yeah its a pain right 😂

@prachi00
Copy link
Member

so I am still unable to reproduce this on my local, someone else can feel free to take a look at this one

@prachi00 prachi00 removed their assignment Jun 26, 2022
@kodabot
Copy link
Collaborator

kodabot commented Jun 26, 2022

ASSIGNMENT OVER - @prachi00 has been unassigned.

@petersopko
Copy link
Contributor Author

so I am still unable to reproduce this on my local, someone else can feel free to take a look at this one

I have noticed just now, this is issue related to Gallery only, collections and their two sort options (new/old first) seem to be working just fine

@petersopko petersopko mentioned this issue Jun 28, 2022
5 tasks
@petersopko petersopko changed the title sort in explorer broken sort in gallery broken Jul 3, 2022
@petersopko petersopko reopened this Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd 🧙‍♀️ - bug-hunt bug Something isn't working p1 preventing everyone from using app
Projects
None yet
3 participants