🔧 bsx gallery sort & buy now

[roiLeo]

⚠️ wait for #3441 before merging this

PR type

• Bugfix

What's new?

• PR closes sort in gallery broken #3266
• PR related Search in gallery BSX #3293
• fix "buy now" toggle in /bsx/explore?page=1&tab=GALLERY
• fix priceMin & priceMax in /bsx/explore?page=1&tab=GALLERY
• fix sort in /bsx/explore?page=1&tab=GALLERY

Before submitting Pull Request, please make sure:

• My contribution builds clean without any errors or warnings
• I've merged recent default branch -- main and I've no conflicts
• I've tried to respect high code quality standards
• I've didn't break any original functionality
• I've posted a screenshot of demonstrated change in this PR

Had issue bounty label?

• Fill up your KSM address: Payout

Screenshot

[netlify]

✅ Deploy Preview for koda-nuxt ready!

Name	Link
🔨 Latest commit	73c4ccb
🔍 Latest deploy log	https://app.netlify.com/sites/koda-nuxt/deploys/62d553271bf3470008990eb1
😎 Deploy Preview	https://deploy-preview-3442--koda-nuxt.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[petersopko]

couple things I've noticed:

• buy now toggle seems to be turned off by default, as opposed to RMRK, i.e. we're showing unlisted nft as default
• when buy now toggle is off (showing unlisted) and I sort NFTs by price high to low, I can still see listed NFTs in the search?
• range slider and setting priceMin + priceMax seems to work, but it need adjustment for bsx
• replace range slider with input fields #3461

[petersopko]

left comment

[roiLeo]

buy now toggle seems to be turned off by default, as opposed to RMRK, i.e. we're showing unlisted nft as default

Done on purpose, no need to hide unlisted item by default (same stuff on all chain).
Buy now toggle off should show all items.
Filters design might be changed after #2947

when buy now toggle is off (showing unlisted) and I sort NFTs by price high to low, I can still see listed NFTs in the search?

I got really weird sorting on bsx

I may have break something

edit:
nvm it's fixed

[petersopko]

looks like rmrk/explore/gallery gets wrong query now?

{
   "errors":[
      {
         "message":"Variable \"$orderBy\" got invalid value null at \"orderBy[0]\"; Expected non-nullable type \"NftEntitiesOrderBy!\" not to be null.",
         "extensions":{
            "code":"BAD_USER_INPUT",
            "exception":{
               "stacktrace":[
                  "GraphQLError: Variable \"$orderBy\" got invalid value null at \"orderBy[0]\"; Expected non-nullable type \"NftEntitiesOrderBy!\" not to be null.",
                  "    at /usr/local/lib/node_modules/@subql/query/node_modules/graphql/execution/values.js:116:15",
                  "    at coerceInputValueImpl (/usr/local/lib/node_modules/@subql/query/node_modules/graphql/utilities/coerceInputValue.js:57:5)",
                  "    at /usr/local/lib/node_modules/@subql/query/node_modules/graphql/utilities/coerceInputValue.js:70:14",
                  "    at Array.map (<anonymous>)",
                  "    at safeArrayFrom (/usr/local/lib/node_modules/@subql/query/node_modules/graphql/jsutils/safeArrayFrom.js:36:23)",
                  "    at coerceInputValueImpl (/usr/local/lib/node_modules/@subql/query/node_modules/graphql/utilities/coerceInputValue.js:68:50)",
                  "    at coerceInputValue (/usr/local/lib/node_modules/@subql/query/node_modules/graphql/utilities/coerceInputValue.js:37:10)",
                  "    at _loop (/usr/local/lib/node_modules/@subql/query/node_modules/graphql/execution/values.js:109:69)",
                  "    at coerceVariableValues (/usr/local/lib/node_modules/@subql/query/node_modules/graphql/execution/values.js:121:16)",
                  "    at getVariableValues (/usr/local/lib/node_modules/@subql/query/node_modules/graphql/execution/values.js:50:19)"
               ]
            }
         }
      }
   ]
}

[roiLeo]

@petersopko should be good now

[petersopko]

pay 100 usd

[yangwao]

😍 Perfect, I’ve sent the payout
💵 $100 @ 60.37 USD/KSM ~ 1.656 $KSM
🧗 DVYy1qnocE8t6ZvUfPx3rEjG829khNRXx3YrCGVHHj19Lcb
🔗 0xb2d781bb33779dbe7feef064897caa8be09f15b6d65a55e7036244348d682596

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues