Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: generic name for components + langDir #3309

Closed
Tracked by #3311
petersopko opened this issue Jun 30, 2022 · 2 comments
Closed
Tracked by #3311

Refactor: generic name for components + langDir #3309

petersopko opened this issue Jun 30, 2022 · 2 comments
Labels
A-refactoring Refactoring stuff, make code more readable, mitigating tech debt

Comments

@petersopko
Copy link
Contributor

following from @roiLeo comment here:

  • Folder structure #3068 (comment)

  • name of our components is currently pretty random, if somebody with an eye for style guides could take this, it would be great.

  • rename langDir folder to locales

  • styles organisation: scss components, themes files // @roiLeo not sure what you meant by this part

ref:
https://v2.vuejs.org/v2/style-guide/?redirect=true#Multi-word-component-names-essential

@petersopko petersopko added the A-refactoring Refactoring stuff, make code more readable, mitigating tech debt label Jun 30, 2022
@petersopko petersopko mentioned this issue Jun 30, 2022
20 tasks
@roiLeo
Copy link
Contributor

roiLeo commented Jun 30, 2022

styles organisation: scss components, themes files // @roiLeo not sure what you meant by this part

Theme file 🔽
In #2947, dark.scss & light.scss, we could extend for personalized chain theme

Scss components 🔽
Personal preference, I like to have components folder in scss to avoid polluting vue components code

And I'll move styles into assets folder (vue/nuxt good pratice)

@roiLeo
Copy link
Contributor

roiLeo commented Mar 28, 2023

Done in #3788 & #2947

@roiLeo roiLeo closed this as completed Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-refactoring Refactoring stuff, make code more readable, mitigating tech debt
Projects
Status: No status
Development

No branches or pull requests

2 participants