Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 rename langDir folder to locales #3788

Merged
merged 3 commits into from
Aug 23, 2022

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Aug 19, 2022

PR type

  • Refactoring

What's new?

Screenshot

Capture d’écran 2022-08-19 à 10 04 40 AM

@roiLeo roiLeo requested review from a team as code owners August 19, 2022 08:13
@roiLeo roiLeo requested review from kkukelka and JustLuuuu and removed request for a team August 19, 2022 08:13
@roiLeo roiLeo added the A-refactoring Refactoring stuff, make code more readable, mitigating tech debt label Aug 19, 2022
@netlify
Copy link

netlify bot commented Aug 19, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit ec7f45b
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6304ab44bf70ad000a26aa45
😎 Deploy Preview https://deploy-preview-3788--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@roiLeo roiLeo requested review from petersopko and removed request for JustLuuuu August 19, 2022 08:14
Copy link
Member

@kkukelka kkukelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checks out 🍏

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Aug 22, 2022
@codeclimate
Copy link

codeclimate bot commented Aug 23, 2022

Code Climate has analyzed commit ec7f45b and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Aug 23, 2022

We'll need to fill up translations where we are missing them.

image

@roiLeo
Copy link
Contributor Author

roiLeo commented Aug 23, 2022

We'll need to fill up translations where we are missing them.

#2 for a more user friendly way of updating translation but we'll still need to add more "word/data" in en.json file

@yangwao
Copy link
Member

yangwao commented Aug 23, 2022

ugh that history, let's put it bit higher 😅

@yangwao yangwao merged commit a01a3aa into kodadot:main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 - clean-up A-refactoring Refactoring stuff, make code more readable, mitigating tech debt S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants