Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Money component #3355

Closed
Tracked by #3311
petersopko opened this issue Jul 6, 2022 · 8 comments 路 Fixed by #6717
Closed
Tracked by #3311

Refactor: Money component #3355

petersopko opened this issue Jul 6, 2022 · 8 comments 路 Fixed by #6717
Labels
A-refactoring Refactoring stuff, make code more readable, mitigating tech debt p3 non-core, affecting less than 40%

Comments

@petersopko
Copy link
Contributor

It's a shared component. It will work well in the same way on moonsama/rmrk/bsx.

!isBsx 馃憖

Yeap, I just found out that. May need some extra work.

Originally posted by @Jarsen136 in #3336 (comment)

Since we're introducing multiple currencies, Money component should be refactored to reflect that in a way which is more robust that current implementation.
@petersopko petersopko added the A-refactoring Refactoring stuff, make code more readable, mitigating tech debt label Jul 6, 2022
@petersopko petersopko mentioned this issue Jul 6, 2022
Open
20 tasks
@Jarsen136
Copy link
Contributor

馃憢

@kodabot
Copy link
Collaborator

kodabot commented Jul 6, 2022

ASSIGNED ISSUES LIMIT REACHED - @Jarsen136, you have been already assigned with 5 issues: 3142,3321,3342,3346,3354. Finish one of them in order to get more issues assigned!

@Jarsen136 Jarsen136 self-assigned this Jul 6, 2022
@kodabot
Copy link
Collaborator

kodabot commented Jul 6, 2022

ASSIGNED - @Jarsen136 馃敀 LOCKED -> Friday, July 8th 2022, 03:38:38 UTC -> 36 hours

@petersopko petersopko added the p5 ideas for future label Jul 6, 2022
@petersopko
Copy link
Contributor Author

@Jarsen136 Sorry I haven't labeled this properly, I don't think we need to rush this as there will be a lot of work on Moonsama release + this is really p5 issue, maybe take something which is more urgent ;) Let's leave it for the chunk of refactors which will be happening a bit later

@Jarsen136 Jarsen136 removed their assignment Jul 6, 2022
@kodabot
Copy link
Collaborator

kodabot commented Jul 6, 2022

ASSIGNMENT OVER - @Jarsen136 has been unassigned.

@roiLeo
Copy link
Contributor

roiLeo commented Jul 12, 2022

@roiLeo roiLeo mentioned this issue Jul 20, 2022
Merged
19 tasks
@roiLeo
Copy link
Contributor

roiLeo commented Aug 22, 2022

Use Intl.NumberFormat

@roiLeo roiLeo mentioned this issue Aug 29, 2022
Open
@roiLeo roiLeo mentioned this issue Oct 3, 2022
Merged
14 tasks
@petersopko
Copy link
Contributor Author

@Jarsen136 馃殌 image

@roiLeo roiLeo added p3 non-core, affecting less than 40% and removed p5 ideas for future labels Oct 12, 2022
@roiLeo roiLeo mentioned this issue Nov 22, 2022
Merged
17 tasks
@roiLeo roiLeo mentioned this issue Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-refactoring Refactoring stuff, make code more readable, mitigating tech debt p3 non-core, affecting less than 40%
Projects
Roadmap Q3Q4
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

馃敡 Vue3 composition Money component roiLeo/nft-gallery
4 participants
@roiLeo @Jarsen136 @petersopko @kodabot