Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💅 top collection responsive & new landing font #4064

Merged
merged 3 commits into from
Oct 3, 2022
Merged

💅 top collection responsive & new landing font #4064

merged 3 commits into from
Oct 3, 2022

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Oct 3, 2022 •
edited

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Had issue bounty label?

  • Fill up your KSM address: Payout

Screenshot

Screenshot 2022-10-03 at 10-11-29 KodaDot - Kusama NFT Market Explorer

@roiLeo roiLeo requested review from a team as code owners October 3, 2022 08:14
@roiLeo roiLeo requested review from kkukelka and petersopko and removed request for a team October 3, 2022 08:14
@netlify
Copy link

netlify bot commented Oct 3, 2022 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 1235ad2
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/633b0d5dca96ba000840ba3a
😎 Deploy Preview https://deploy-preview-4064--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@petersopko
Copy link
Contributor

@roiLeo to followup from the issue:

size of screen? Numbers are big, it make multiple lines, I might reduce the collection name text

screen was 16 inch, looks very well now ✅

@petersopko
Copy link
Contributor

just one thing, don't we want to include some formatting to the numbers?

image

kinda hard to read, or is it just me?

@roiLeo
Copy link
Contributor Author

roiLeo commented Oct 3, 2022 •
edited

just one thing, don't we want to include some formatting to the numbers?

image

kinda hard to read, or is it just me?

I completely agree, ref #3355 (#3355 (comment))

petersopko
petersopko approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@petersopko petersopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm

@roiLeo roiLeo added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Oct 3, 2022
kkukelka
kkukelka approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@kkukelka kkukelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@codeclimate
Copy link

codeclimate bot commented Oct 3, 2022

Code Climate has analyzed commit 1235ad2 and detected 0 issues on this pull request.

View more on Code Climate.

@kkukelka kkukelka merged commit 468aa86 into kodadot:main Oct 3, 2022
@kkukelka
Copy link
Member

kkukelka commented Oct 3, 2022

pay 100 usd

@yangwao
Copy link
Member

yangwao commented Oct 3, 2022

😍 Perfect, I’ve sent the payout
💵 $100 @ 42.38 USD/KSM ~ 2.36 $KSM
🧗 DVYy1qnocE8t6ZvUfPx3rEjG829khNRXx3YrCGVHHj19Lcb
🔗 0xc034b1e149b1a2dc09ceb04fb55271f974c1e53e5090cb9a80bacdf58d764a04

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Oct 3, 2022
@roiLeo roiLeo deleted the fix/responsive/top-collection branch October 25, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkukelka kkukelka kkukelka approved these changes

@petersopko petersopko petersopko approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roiLeo @petersopko @kkukelka @yangwao